-
-
Notifications
You must be signed in to change notification settings - Fork 728
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replacing qs
with qs-esm
or picoquery
#566
Comments
This is related to #453 (discussion around custom parameters for Also, worth noting that current usage of body-parser/lib/types/urlencoded.js Lines 165 to 174 in 80fbb76
(For reference, these are the options supported by
|
This has been brought up a bunch of times, and I dont have time right now to go find all my responses, but the TLDR is that I remain unconvinced that transitive dependency count is a metric we want to optimize around. If you can make a case which is more comprehensive around the performance impact of installs then please do so, but this conversation has pretty much stalled out every time I have asked this of anyone in the past. edit: found this which I think this was the most comprehensive issue opened so far: expressjs/express#5723 |
I want to propose to move from
qs
toqs-esm
orpicoquery
.qs
seems to pull in a lot of dependencies that are not needed in your specified engine anymoreqs-esm
has the same engine requirements than the newest body parser version. However, sincerequire(esm)
will most likely not be available for node 18,picoquery
seems to be the only viable solution.I would be happy to create a PR if you are on board with this.
The text was updated successfully, but these errors were encountered: