Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EFI: Codeowners #178

Open
sheplu opened this issue Feb 20, 2024 · 2 comments
Open

EFI: Codeowners #178

sheplu opened this issue Feb 20, 2024 · 2 comments

Comments

@sheplu
Copy link
Member

sheplu commented Feb 20, 2024

Motivation

Automation can only be effective if setup correctly. Relying on Codeowners can great help the automation allowing us to automatically notify specific people when a Pull Request is opened on specific part of the project.
It can also be used to notify specific team depending on the change, for example a security group or technical writer if this only change some documentation

Expectation

Implement Codeowners files in each repositories and setup them accordingly

Implementation

Setup codeowner

Status

Part: Organization

Draft

In a project, all changes are not equal and the risk is not the same. Contributions to the core package need to be reviewed extensively to ensure the highest quality but other parts are less critical. By using codeowners file, we can automatically manage this risk and allocate specific teams to review pull requests.
For example, a change only targeting documentation or test could be reviewed and validated by the triager team (or another specific team) and does need less approval (maybe only 1-2) while changes in the core of the package may require more validations (3-4 approvals by specific members)

@wesleytodd
Copy link
Member

How do we see this working with the Captains? I guess I would think that each captain would also be a code owner in the repo. I guess then we would need to setup those files and approval rules?

@bjohansebas
Copy link
Member

bjohansebas commented Nov 19, 2024

Implementing this in the website repository would be great, it would provide great automation, as there are sections of the website where people are specialized or are directly responsible for maintaining them.

I will open a PR to propose it.

Edit: Maybe we need to investigate this a bit more, since write permissions are required for the people or teams listed in the file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants