Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How come only bodyParser.json is exposed? #3674

Closed
willowiscool opened this issue Jun 19, 2018 · 2 comments
Closed

How come only bodyParser.json is exposed? #3674

willowiscool opened this issue Jun 19, 2018 · 2 comments
Labels

Comments

@willowiscool
Copy link

willowiscool commented Jun 19, 2018

This module depends on body-parser and exposes bodyParser.json. However, if someone wanted to get the pure text result of the output, or use another method from body-parser, they'd have to install it themselves. Why not just expose all of the functions and save the user an extra install? Or not expose anything, and make the module lighter?

@wesleytodd
Copy link
Member

I think the general idea was to remove all these originally, but the json one was brought back. I looked quickly for the old conversations but it was too long ago for me to remember what to look for.

I do think, if the choice is to include any, then all should be exposed. But maybe there was some question about this someone else would remember better.

@dougwilson
Copy link
Contributor

The others are being exposed in Express 4.17. Follow the release and what it includes in #3778

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants