-
Notifications
You must be signed in to change notification settings - Fork 532
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
conflicting req/res scoped variable names #142
Comments
That is a good idea. In order to use Any thoughts on alternative solutions instead of |
@dougwilson According to node.green, That said, it looks like you still maintains 0.10 compatibility in express, so I can understand wanting to look for alternatives to |
So I've been looking at #141 today and I believe the changes to fix that issue would ultimately fix this issue too, as it will move all these to private and instance based, so wouldn't conflict with other modules either. |
I read that you guys are thinking of a version 2.0 for morgan on one of the other issues..
I didn't see a 2.0 branch so I wasn't sure what your plans are, but I was wondering if you would be implementing the ES6 Symbol technique as to not conflict with any other express middleware that could be trying to store _startTime and such on req/res.
So some something like
The text was updated successfully, but these errors were encountered: