This repository has been archived by the owner on Jan 16, 2023. It is now read-only.

Suggestion list for badge content #2

Open

fooman opened this issue Mar 10, 2020 · 1 comment

Contributor

fooman commented Mar 10, 2020 •

edited

Loading

For now unordered bucket list (to be sorted/grouped/structured later):

Follows Magento coding standards
- Count of errors / warnings in module
Declares dependencies
- Are any missing?
- Consistency in modules.xml & composer.json
Has blocks that disable FPC
- cacheable="false"
Uses preferences?
- though would need to look closer as to why they were used
Includes some test coverage?
Is it on the marketplace?
Reviews (are there any?)

Regarding cachable=false, maybe it would be good to check for that on certain handles, like catalog_category_view and catalog_product_view

But on custom pages that are dynamic, it wouldn't really matter

Contributor Author

fooman commented Mar 10, 2020

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.