Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rule: No usage of $block->getHelper() in PHTML #26

Open
navarr opened this issue May 9, 2018 · 2 comments
Open

Rule: No usage of $block->getHelper() in PHTML #26

navarr opened this issue May 9, 2018 · 2 comments
Labels
accepted This rule is accepted by extdn

Comments

@navarr
Copy link

navarr commented May 9, 2018

In versions of Magento 2.2+ (where View models exist)
@navarr navarr changed the title Rule: No usage of `$block->getHelper() in PHTML Rule: No usage of $block->getHelper() in PHTML Jul 2, 2018
@schmengler schmengler added on agenda of hangout This issue will be discussed in the next open hangout accepted This rule is accepted by extdn and removed on agenda of hangout This issue will be discussed in the next open hangout labels Jul 26, 2018
@schmengler
Copy link
Collaborator

low severity, to discourage own helpers instead of view models but still allow core helpers

@jissereitsma
Copy link
Contributor

To further comment on this, the rule might still be useful. So it can be created and submitted via PR. However, as @schmengler mentioned, the severity should be low.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
accepted This rule is accepted by extdn
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@navarr @schmengler @jissereitsma