Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rule: Analyse Missing Modules in app/etc/config.php #43

Open
larsroettig opened this issue Jun 11, 2018 · 2 comments
Open

Rule: Analyse Missing Modules in app/etc/config.php #43

larsroettig opened this issue Jun 11, 2018 · 2 comments
Labels
debate needed on agenda of hangout This issue will be discussed in the next open hangout

Comments

@larsroettig
Copy link
Contributor

Rule

If exist app/etc/config.php we should analyse the File for missing modules.

Use Case if use extdn-phpcs for a Magento costumer project
@schmengler schmengler added the on agenda of hangout This issue will be discussed in the next open hangout label Jul 26, 2018
@schmengler
Copy link
Collaborator

Seems out of scope for a tool that targets code quality, but let's discuss

@jissereitsma
Copy link
Contributor

Discussed this in a meeting of July 30th. It seems out of scope for PHPCS (another tool would be better suitable) and out of scope for the focus of this project (extension quality). Suggested was to create a bin/magento command instead for this - like module:validate. This command could check for registration.php files to see if the module is there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
debate needed on agenda of hangout This issue will be discussed in the next open hangout
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@schmengler @larsroettig @jissereitsma