Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

document doesn't react to all files changes #247

Open
CGMossa opened this issue Feb 27, 2023 · 1 comment
Open

document doesn't react to all files changes #247

CGMossa opened this issue Feb 27, 2023 · 1 comment

Comments

@CGMossa
Copy link
Member

CGMossa commented Feb 27, 2023

Via #246 rextendr::document doesn't re-compile in case you change .cargo/config.toml-file.

The detection of needing to compile comes from pkgbuild.
This extra rust feature was provided by way of r-lib/pkgbuild@2fd13d9

Here it is clearly stated that rs-files and Cargo.toml are the only sensitive ones to recompilation.

There was talk of adding a configurable feature via DESCRIPTION-file, but this was abandoned.

Do we suggest the following additions:

  • Recompile if .cargo\config.toml has changed, or .cargo\config? Actually it needs to be **/.cargo/config.toml atleast.
  • rust-toolchain.toml file should also provoke a change.
  • ???

I'd rather we gather the exact glob-list before making an issue over at pkgbuild.

@Ilia-Kosenkov
Copy link
Member

How about we track *rs and *toml? Feels like all of them should affect compilation, no?
And by we I mean ask {pkgbuild} :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants