Skip to content
This repository has been archived by the owner on Jul 26, 2022. It is now read-only.

fix: remove AWS_DEFAULT_REGION #794

Merged
merged 1 commit into from
Sep 22, 2021
Merged

Conversation

Flydiverny
Copy link
Member

Not sure why AWS_DEFAULT_REGION was added in the first place, but it seems misleading to have. Its not provided in the docs everywhere and the AWS SDK for JS uses AWS_REGION so the AWS_DEFAULT_REGION should not be used, if one uses the aws cli it does seem to prefer AWS_DEFAULT_REGION though in some cases 😄

Signed-off-by: Markus Maga <markus@maga.se>
Copy link
Member

@moolen moolen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That makes sense, this is a big inconsistency in the aws sdks.

@Flydiverny Flydiverny merged commit 45e8948 into master Sep 22, 2021
@Flydiverny Flydiverny deleted the remove-aws-default-region branch September 22, 2021 01:23
@arischow
Copy link

@Flydiverny

I think after this change, there should be a new Helm chart version release? Well I am new to this repo but I have to say after installing this chart, this environment variable did confuse me, especially I specified the region (AWS_REGION) to another one.

@Flydiverny
Copy link
Member Author

@arischow should be a new release cut now :)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants