Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ctrl+U and Ctrl+D for page up/down #109

Closed
juancampa opened this issue Jun 4, 2020 · 2 comments · Fixed by #234
Closed

Ctrl+U and Ctrl+D for page up/down #109

juancampa opened this issue Jun 4, 2020 · 2 comments · Fixed by #234
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@juancampa
Copy link

Is your feature request related to a problem? Please describe.
Some keyboards (like mine) don't really have PgUp/PgDown. It would be great to have another keybinding to quickly scroll up and down the Diff pane.

Describe the solution you'd like

New keybindings:

  • Ctrl+U to scroll up
  • Ctrl+D to scroll down

These are the keybindings for vi/vim so a lot of folks should be familiarized with them.

@extrawurst
Copy link
Owner

extrawurst commented Jun 5, 2020

Hi @juancampa thanks for your interest in gitui, I will never get used to those vi bindings, but I guess I am no benchmark here :D

one alternative I could imagine is:

Event::Key(KeyEvent { code: Down, modifiers: SHIFT | CONTROL })
Event::Key(KeyEvent { code: Up, modifiers: SHIFT | CONTROL })

this would be close the already supported shift+up as a home alternative

for vi fans this of course can be modified with #57

@extrawurst extrawurst added enhancement New feature or request good first issue Good for newcomers labels Jun 5, 2020
@hasufell
Copy link

I think vi bindings have no place here. The other navigational keys are arrow keys. So the natural choice should be PageUp/PageDown.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants