Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove hardcoded blue background color #129

Closed
jantari opened this issue Jun 15, 2020 · 3 comments
Closed

Remove hardcoded blue background color #129

jantari opened this issue Jun 15, 2020 · 3 comments
Labels
question Further information is requested

Comments

@jantari
Copy link

jantari commented Jun 15, 2020

Is your feature request related to a problem? Please describe.
It appears gitui uses a hardcoded blue color in some of its UI elements, such as the bottom shortcut row, the currently selected file on the top left and the diff header with the line information on the right. This blue color does not fit into most themes and may cause visibility and contrast problems with some.

Describe the solution you'd like
Use the terminals DarkBlue color palette instead of hardcoding colors.

Describe alternatives you've considered
None

Additional context
Screenshot of gitui with GruvBox Dark theme:
image

@extrawurst
Copy link
Owner

Hi @jantari thanks for your interest in gitui. You can customise all colors following this guide: https://github.com/extrawurst/gitui/blob/master/THEMES.md

let me know if there is anything you cannot customise to match your taste.

@extrawurst extrawurst added the question Further information is requested label Jun 15, 2020
@jantari
Copy link
Author

jantari commented Jun 15, 2020

It is nice that the theme can be customized to take advantage of the 24bit True color terminals we have these days, but I think the default should be to use the terminals palette.

@extrawurst
Copy link
Owner

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants