Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Impossible to configure color of title of current active block #2052

Closed
cgahr opened this issue Feb 16, 2024 · 4 comments · Fixed by #2054
Closed

Impossible to configure color of title of current active block #2052

cgahr opened this issue Feb 16, 2024 · 4 comments · Fixed by #2054

Comments

@cgahr
Copy link

cgahr commented Feb 16, 2024

Describe the bug
It is not possible to configure the color of the title of the currently active block directly. That's the orange part on the following screenshot:
image

As far as I can tell, gitui use color4 of the terminal instead.

Expected behavior
There should the option to configure this style element directly using the config.

Context (please complete the following information):

  • OS/Distro + Version: Ubuntu 22.05 LTS
  • GitUI Version 0.24.3
  • Rust version: no installed

Additional context
Add any other context about the problem here.

@cgahr cgahr added the bug Something isn't working label Feb 16, 2024
@extrawurst extrawurst added feature-request and removed bug Something isn't working labels Feb 16, 2024
@extrawurst
Copy link
Owner

This is not a feature yet, not a bug

@cgahr
Copy link
Author

cgahr commented Feb 16, 2024

Any pointer, which part of the code I have to touch if I want to implement this myself?

@extrawurst
Copy link
Owner

@cgahr by looking into how it would be done I saw its just this simple change, so I did it. please feel free to review it and pick up another good-first-issue

@cgahr
Copy link
Author

cgahr commented Feb 18, 2024

Thank you so much, I'm happy it was a very small change.

I think, however, that you might have introduced a bug while implementing this, see #2056.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants