Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Selection cursor not moving after deleting a stash at the end of the list #223

Closed
hansmuff opened this issue Aug 5, 2020 · 1 comment
Closed
Labels
bug Something isn't working

Comments

@hansmuff
Copy link

hansmuff commented Aug 5, 2020

Describe the bug
[MINOR INCONSISTENCY] When on the Stashes[4] screen and multiple stashes are present and you delete the last one, the cursor doesn't move.

To Reproduce
Steps to reproduce the behavior:
Go to Stashes[4] and have multiple stashes
Jump to the last one, I use SHIFT+CursorDown
Hit "D" and then ENTER
Now there's no cursor bar. If I hit "D" again, nothing happens because nothing is selected.

Expected behavior
When you're on any but the last stash, deleting the stash you are on leaves the cursor "in place" and the stash below the one you delete gets selected. I expect that when I select the last one, the selection realizes there's no next one, and instead goes one back.

Screenshots
Not required for this, I think :)

Context (please complete the following information):

  • Windows 10 on Windows Terminal (from the App Store)
  • GitUI Version 0.8.0
  • Rust version: N/A

Additional context
Fairly straightforward. It's not really a problem, it's a small inconsistency.

@extrawurst
Copy link
Owner

Thanks for reporting this @hansmuff

@extrawurst extrawurst added the bug Something isn't working label Aug 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants