Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

msi try 2 #360

Merged
merged 5 commits into from
Oct 26, 2020
Merged

msi try 2 #360

merged 5 commits into from
Oct 26, 2020

Conversation

pm100
Copy link
Contributor

@pm100 pm100 commented Oct 25, 2020

try 2

@pm100
Copy link
Contributor Author

pm100 commented Oct 25, 2020

OK, i have modded ci.yml to run a modified Makefile, the makefile build the msi and places it in the release dir

I have changed cd.yml to pick up the msi - but I cant test that.

I will revert the change to ci.yml

@extrawurst extrawurst merged commit a4d7417 into extrawurst:master Oct 26, 2020
@extrawurst
Copy link
Owner

@pm100 thanks! we will do a release candidate before releasing 0.11 then the CD will run and we can test it.
can you create expressive commits in future PRs please? :)

@pm100
Copy link
Contributor Author

pm100 commented Oct 26, 2020

i need to revert ci.yml first - it still does the wix build as a test

This was referenced Oct 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants