Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

merging (with conflicts) #485

Closed
extrawurst opened this issue Jan 11, 2021 · 4 comments
Closed

merging (with conflicts) #485

extrawurst opened this issue Jan 11, 2021 · 4 comments
Labels
Milestone

Comments

@extrawurst
Copy link
Owner

this will be a multistep process:

  • non-ff merging will put the repo in conflicted state (<<<< in the files)
  • user resolved conflicts outside of gitui
  • now we provide means to put repo into resolved state
  • committing from this state should auto fill the commit msg with the typical merge commit text
  • at any step we need to provide means to abort/revert the ongoing merge
@stale stale bot added the wontfix This will not be worked on label Apr 11, 2021
Repository owner deleted a comment from stale bot Apr 11, 2021
@stale stale bot removed the wontfix This will not be worked on label Apr 11, 2021
@extrawurst extrawurst added this to the v0.15 milestone Apr 12, 2021
@extrawurst extrawurst modified the milestones: v0.15, v0.16 Apr 25, 2021
@extrawurst
Copy link
Owner Author

turns out git2-rs lacks support for: git_repository_mergehead_foreach (issue: rust-lang/git2-rs#705)

we need that to be able to figure out which branch is currently about to be merged

@extrawurst
Copy link
Owner Author

extrawurst commented May 9, 2021

update:

  1. we now can merge in arbitrary branches from the branch list
  2. we can undo a ongoing merge state (revert/reset, cleanup repo)

what's left to do:

  • asking to do a merge commit right away if no conflicts
  • helping with the typical merge commit msg if manually committing the merge

Screenflick Movie 10

@extrawurst extrawurst mentioned this issue May 10, 2021
@extrawurst extrawurst changed the title merging with conflicts merging (with conflicts) May 12, 2021
@extrawurst
Copy link
Owner Author

extrawurst commented May 12, 2021

ok update time:

  1. we can commit a merge now
  2. we make use of standard MERGE_MSG file to repopulate merge commit msg

that leaves us with only a few small todos:

  • do ff merge if possible and desired
  • remove limitation that a pull has to be conflict free

Screenflick Movie 11

@extrawurst
Copy link
Owner Author

extrawurst commented May 12, 2021

closed with 8767642

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant