-
-
Notifications
You must be signed in to change notification settings - Fork 568
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
more reliable and readable unittest for force push #537
Labels
bug
Something isn't working
dormant
Marked by stale bot on close
good first issue
Good for newcomers
Comments
I can try this |
How do I assign it to myself? |
Just open a PR when you are ready and mention this issue in it 👍 |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
bug
Something isn't working
dormant
Marked by stale bot on close
good first issue
Good for newcomers
based off of #534 (and #535):
Currently
@WizardOhio24 it looks like the internals of
repo_init
were unclear: it creates independent temporary test repositories (including an empty commit).the current unittests both test essentially the same thing:
only difference is that the second unittest
test_force_push_rewrites_history
does some additional checks that the right commit IDs are in(c)
at the end.Desired
test_force_push
can be simplified to just test that we can overwrite (c) with (b) - no additional file need to be committeda real life use case would be nice where we actually create a repo (a), clone (a) to (b) and then have two commits that collide and test that force does what it should
The text was updated successfully, but these errors were encountered: