when select log[2] panic

[jellybobbin]

env

macos     10.14.6
gitui     0.8.1
iterm2    3.3.4

git log (It's a test, usually not very long)

commit 060deab38708174af142e79dee5f1abddee2bcd5 (HEAD -> master, origin/master)
Author: jelly <jellybobbin@gmail.com>
Date:   Thu Feb 25 09:18:16 2021 +0800

    兼容力報基础功能兼容力報基础功能兼容力報基础功能兼容力報基础功能兼容力報基础功能兼容力報基础功能兼容力報基础功能兼
容力報基础功能兼容力報基础功能兼容力報基础功能兼容力報基础功能兼容力報基础功能兼容力報基础功能兼容力報基础功能兼容力報
基础功能兼容力報基础功能兼容力報基础功能兼容力報基础功能兼容力報基础功能兼容力報基础功能兼容力報基础功能兼容力報基础功
能兼容力報基础功能

gitui

panic: PanicInfo { payload: Any, message: Some(byte index 100 is not a char boundary; it is inside '容' (bytes 99..102) of `兼容力報基础功能兼容力報基础功能兼容力報基础功能兼容力報基础功能兼容力報基础功能兼容力報基础功能兼容力報基础功能兼容力報基础功能兼容力報基础功能兼容力報基础功能兼容力報基`[...]), location: Location { file: "/private/tmp/rust-20200705-74315-rfuccz/rustc-1.44.1-src/src/libcore/str/mod.rs", line: 1920, col: 47 } }
trace:
   0: backtrace::capture::Backtrace::new
   1: gitui::set_panic_handlers::{{closure}}
   2: std::panicking::rust_panic_with_hook
   3: _rust_begin_unwind
   4: core::panicking::panic_fmt
   5: core::str::slice_error_fail
   6: core::str::traits::<impl core::slice::SliceIndex<str> for core::ops::range::Range<usize>>::index::{{closure}}
   7: core::str::traits::<impl core::ops::index::Index<I> for str>::index
   8: asyncgit::sync::commits_info::get_message
   9: asyncgit::sync::commits_info::get_commits_info
  10: gitui::tabs::revlog::Revlog::update
  11: gitui::main
  12: std::rt::lang_start::{{closure}}
  13: _main

But when the item window is properly sized, it is normal:

[extrawurst]

To allow me to reproduce this I would need to have the full commit message or author name that contains this Unicode character.

edit: also please provide the terminal size you tried this in

the Issue template asks for more information like the gitui version you used, please provide them

[extrawurst]

see #188 as reference

[jellybobbin]

ok,thanks...
but it happened in my work, not at home (version 0.11.0), I need to confirm the version information tomorrow...

I will describe the process of reappearance tomorrow.

[extrawurst]

but it happened in my work, not at home (version 0.11.0), I need to confirm the version information tomorrow...

please also provide me with as much data as possible to reproduce this, the problem must be some unicode rendering that breaks but In order for this to be reproducible I need the message/author name that makes it break

[jellybobbin]

but it happened in my work, not at home (version 0.11.0), I need to confirm the version information tomorrow...

please also provide me with as much data as possible to reproduce this, the problem must be some unicode rendering that breaks but In order for this to be reproducible I need the message/author name that makes it break

No problem. In fact, it happened in two existing warehouses

[extrawurst]

No problem. In fact, it happened in two existing warehouses

I assume a warehouse is a git repository? :)
if so its no wonder, its utf8 related and you probably use a lot multibyte characters in your names and commit messages

[jellybobbin]

No problem. In fact, it happened in two existing warehouses

I assume a warehouse is a git repository? :)
if so its no wonder, its utf8 related and you probably use a lot multibyte characters in your names and commit messages

Yes, it's a git repository, so is it normal?

[jellybobbin]

@extrawurst

I used itrem2. I found it related to the size of the itrem2 window. When the itrem2 window is just the right size, it's normal. There are problems with everything else.

[extrawurst]

@jellybobbin I just realize you created the same issue already in the past: #420
Now that you provided the information that this happens in gitui 0.8.1 the answer is going to be the exact same:

version 0.8.1 is super old and this bug is already fixed. please update or provide a reproduction that still crashes the most recent version.

the fix for this is in cb3b968 and was released in version 0.9.0 (on 29 Jul 2020)

[jellybobbin]

maybe it's too long and I forgot it.,thx..