Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stale bot misconfigured? #815

Closed
sztomi opened this issue Jul 12, 2021 · 5 comments
Closed

Stale bot misconfigured? #815

sztomi opened this issue Jul 12, 2021 · 5 comments

Comments

@sztomi
Copy link

sztomi commented Jul 12, 2021

I searched this issue tracker for rebase support and found #302

It is labeled as WONTFIX, but the discussion doesn't seem to imply that it's not intended to be added (I'm also not sure if it's beneficial to close "stale" issues with substantial, forward looking discussion).

@extrawurst
Copy link
Owner

I don't think it is misconfigured. So far it does what it should: Close tickets without activity, after all closed tickets are not deleted. They are still around for reference.

What would you configure differently?

Just an oversight in this particular example, issues we don't want to see getting closed can be marked as such.

@sztomi
Copy link
Author

sztomi commented Jul 12, 2021

What would you configure differently?

@extrawurst labeling the issue as WONTFIX seems to be misleading and that was done by the bot. Had I not opened the issue and read the discussion I would have gotten the impression that rebase support is out of scope for this project, but that doesn't seem to be the case. I'm not sure if all bot-closed issues get this label, but I would personally not do this (instead, maybe add a label that implies closing due to staleness, i.e. something like closed:stale).

For the second part (not closing issues with substantial and forward looking discussion), labeling something uncloseable seems to be a good solution. In that case, maybe #302 is worth reopening and labeling as such.

@extrawurst
Copy link
Owner

for me the paper trail where a label comes from is well document by this:

Screenshot 2021-07-12 at 14 18 11

if you care enough for a feature you check out the issue that was closed and marked as wont-fix and realise that it was the bot. then you can followup and bring this back into attention or even better offer help in implementing it 😁

I created a more concise followup ticket for this feature now: #816

@sztomi
Copy link
Author

sztomi commented Jul 12, 2021

But why label with a word that means something else? There was a very real chance that I wouldn't have opened that issue since I saw the label that, to me, clearly means that the author does not want to support the feature. Not looking for the paper trail (on the off chance that WONTFIX means stale, which I never would have imagined) doesn't mean I wouldn't care about the feature. The label tells me it's out of scope and those decisions are rarely up for debate. So I had no other reason than curiosity to read the discussion.

This also makes it impossible to filter for WONTFIX issues that are actually out of scope for the project.

(don't get me wrong, I don't mean to push my views on this, I'm just very confused why it's done the way it is, with seemingly no real upside - compared to labeling stale issues with a descriptive word)

@extrawurst
Copy link
Owner

But why label with a word that means something else? There was a very real chance that I wouldn't have opened that issue since I saw the label that, to me, clearly means that the author does not want to support the feature. Not looking for the paper trail (on the off chance that WONTFIX means stale, which I never would have imagined) doesn't mean I wouldn't care about the feature. The label tells me it's out of scope and those decisions are rarely up for debate. So I had no other reason than curiosity to read the discussion.

This also makes it impossible to filter for WONTFIX issues that are actually out of scope for the project.

(don't get me wrong, I don't mean to push my views on this, I'm just very confused why it's done the way it is, with seemingly no real upside - compared to labeling stale issues with a descriptive word)

I have nothing to add, let's discuss this further on discord if you want to

@extrawurst extrawurst added the dormant Marked by stale bot on close label Jul 12, 2021
@extrawurst extrawurst removed the dormant Marked by stale bot on close label Jul 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants