-
Notifications
You must be signed in to change notification settings - Fork 560
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SVGView svgNode property made open var instead of fileprivate var #108
Comments
Not sure I understand your use case. |
The use case I have is dynamically changing the svg (using SVGParser to get a new root node) while also getting the benefit of the content mode resizing provided in the SVGView class. MacawView provides the ability to change the svg root node, but doesn't allow for content mode scaling. I'd like the ability to set a new root node on the SVGView, just like you can set a new filename and have it re-render for the correct content mode. |
Sorry for late response. I got your point, but still thinking that using SVGView with dynamic content might be too complicated. A better solution would be to add content mode to MacawView. And I think we can implement it in one of upcoming releases. For now you can just copy&paste SVGView implementation to your code and customize it as you like. |
Awesome that's good to hear! |
|
It would be nice if the svgNode property on the SVGView was open, not fileprivate. Currently there is no way to dynamically change the svg on the SVGView without changing the filename. This prevents a previously parsed svg node from being set on the SVGView with the proper content mode without creating a new instance of SVGView.
The text was updated successfully, but these errors were encountered: