Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make bounds() not optional and as a var #240

Closed
JoachimM7 opened this issue Dec 5, 2017 · 1 comment
Closed

Make bounds() not optional and as a var #240

JoachimM7 opened this issue Dec 5, 2017 · 1 comment
Assignees
Milestone

Comments

@JoachimM7
Copy link
Contributor

Two suggestions:

  1. Why is bounds() optional? It's a little bit annoying always to unwrap it. Only in the Image-class there is the possibility, that there will be no Rect as a return. So maybe you could only make this one optional?

  2. As in the newer Swift-versions it would be nicer, if bounds is a property and not a function?

@ystrot ystrot self-assigned this Dec 12, 2017
@ystrot ystrot added this to the 0.9.2 milestone Dec 12, 2017
@ystrot
Copy link
Member

ystrot commented Dec 12, 2017

Thanks for your comments! I agree with you, but it actually makes implementation much more complicated. However we decided to provide quick and working solution for now and then make it optimal. Regarding property/method - I don't think it makes a lot of sense. It can't be assigned and implementation looks too complicated for a "property".

I'm closing this ticket and if you have more comments please let's keep discussion in a single place here: #252

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants