Morphing animation scale/translate/rotation #427
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # Source/svg/SVGCanvas.swift
ystrot
requested changes
Jul 9, 2018
Source/svg/SVGCanvas.swift
Outdated
| @@ -19,7 +19,7 @@ class SVGCanvas: Group { | |||
| layout.layout(node: self, in: size) | |||
| return size | |||
| } | |||
|
|
|||
Source/svg/SVGNodeLayout.swift
Outdated
| @@ -40,6 +40,7 @@ class SVGSize { | |||
|
|
|||
| protocol NodeLayout { | |||
|
|
|||
| var svgSize: SVGSize { get } | |||
There was a problem hiding this comment.
Avoid using svgSize in general protocol
Source/views/MacawView.swift
Outdated
| if let view = nodesMap.getView(canvas) { | ||
| rect = canvas.layout(size: view.bounds.size.toMacaw()).rect() | ||
| } else { | ||
| rect = Group(contents: canvas.contents).bounds |
There was a problem hiding this comment.
Not really effective. It's better to use utility method to get bounds for list of nodes which will be used here and in Group.bounds
| @@ -31,6 +31,7 @@ open class Group: Node { | |||
| tag: tag | |||
| ) | |||
|
|
|||
| self.contents = contents | |||
There was a problem hiding this comment.
You change both contentsVar and contents which is not necessary, because contentsVar will be updated automatically.
There was a problem hiding this comment.
node property for contentsVar is being set up here, not the contents which indeed will be updated automatically
ystrot
approved these changes
Jul 17, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.