Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typo in Rect.center()? #449

Closed
beta opened this issue Jul 13, 2018 · 1 comment
Closed

Typo in Rect.center()? #449

beta opened this issue Jul 13, 2018 · 1 comment
Assignees
Milestone

Comments

@beta
Copy link

beta commented Jul 13, 2018

https://github.com/exyte/Macaw/blob/master/Source/model/geom2d/Rect.swift#L35

open class Rect : Locus {
    ...
    open func center() -> Point {
        return Point(x: x + w / 2, y: y + w / 2)
    }
    ...
}

IMHO the second param should be y + h / 2. Is this a typo?

@ystrot ystrot closed this as completed in 34e381f Jul 13, 2018
@ystrot ystrot self-assigned this Jul 13, 2018
@ystrot ystrot added this to the 0.9.3 milestone Jul 13, 2018
@ystrot
Copy link
Member

ystrot commented Jul 13, 2018

Thanks for a good catch! Fixed in the master branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants