Remove nodes map #506
Merged
Remove nodes map #506
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ystrot
requested changes
Nov 9, 2018
| @@ -490,7 +498,7 @@ | |||
| PRODUCT_NAME = "$(TARGET_NAME)"; | |||
| PROVISIONING_PROFILE = ""; | |||
| PROVISIONING_PROFILE_SPECIFIER = ""; | |||
| SWIFT_VERSION = 4.2; | |||
| SWIFT_VERSION = 4.0; | |||
| @@ -13,27 +13,38 @@ class AnimationUtilsTests: XCTestCase { | |||
|
|
|||
| func testIndex() { | |||
| let rootGroup = Group() | |||
| let a = Node() | |||
| let a = Shape(form: Locus()) | |||
There was a problem hiding this comment.
What do we create fake Locus here? Locus not an abstract class just because Swift doesn't support it. So it's better to use real form, even for tests.
| @@ -22,7 +22,8 @@ enum AnimationType { | |||
|
|
|||
| class BasicAnimation: Animation { | |||
|
|
|||
| var nodeId: String? | |||
| weak var node: Node? | |||
There was a problem hiding this comment.
Can we keep only renderer reference? I though we can get node from renderer.
There was a problem hiding this comment.
you can create animation when there are no renderers yet. You have to remember something, to later assign renderer to it
|
|
||
| guard let macawView = nodesMap.getView(node) else { | ||
| guard let macawView = animation.nodeRenderer?.view as? MacawView else { |
There was a problem hiding this comment.
Can we make NodeRenderer.view a MacawView to avoid casting?
ystrot
approved these changes
Nov 9, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.