Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong SVG rendering #632

Open
sam-moshenko opened this issue Oct 16, 2019 · 5 comments
Open

Wrong SVG rendering #632

sam-moshenko opened this issue Oct 16, 2019 · 5 comments
Assignees
Milestone

Comments

@sam-moshenko
Copy link

This SVG file is rendered with errors:
http://s000.tinyupload.com/?file_id=51455686831478467750
The image shows how Macaw displays it(top), and how it should be(bottom):
image
I see two problems here:

  1. Gradient is rendered just as plain black, not green to white as it should be
  2. Path of the gradient is wrong, it should go all the way to the bottom instead of going right from end of path to beginning

Is there any workarounds these errors? Will it be fixed?

thanks for the Cocoapod anyway, it is pretty cool

@amarunko
Copy link
Contributor

Hi, @sam-moshenko, one of the problems related to the wrong gradient stops parsing, I will try to fix this soon, also you can always help by sending a PR.

@amarunko
Copy link
Contributor

Fix for gradient stops - #638

@ystrot ystrot self-assigned this Nov 28, 2019
@ystrot ystrot added this to the 0.9.6 milestone Nov 28, 2019
@ystrot
Copy link
Member

ystrot commented Nov 28, 2019

After merging PR linear gradient parsed correctly, but black parts are still there. Looks like a rendering issue.

@amarunko
Copy link
Contributor

Honestly, I didn't find any white fill for all SVG/Group, only fill = "none", which one btw not parsed, but shouldn't affect anything for this SVG, maybe I missed something.

@ystrot ystrot modified the milestones: 0.9.6, 0.9.7 Apr 10, 2020
@ystrot ystrot modified the milestones: 0.9.7, 0.9.x Jul 28, 2020
@miguelc95
Copy link

Maybe this is too late but I had the same issue and adding a transparent fill to the path in the SVG solved the problem

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants