Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SVGParser crashed on specific SVG file #662

Open
zalexej opened this issue Jan 14, 2020 · 2 comments
Open

SVGParser crashed on specific SVG file #662

zalexej opened this issue Jan 14, 2020 · 2 comments

Comments

@zalexej
Copy link

zalexej commented Jan 14, 2020

#0 0x000000010d55d9d9 in SVGParser.parsePattern(:) at Pods/Macaw/Source/svg/SVGParser.swift:389
#1 0x000000010d5545b6 in SVGParser.prepareSvg(
:) at Pods/Macaw/Source/svg/SVGParser.swift:162
#2 0x000000010d553b6a in closure #1 in SVGParser.prepareSvg(:) at Pods/Macaw/Source/svg/SVGParser.swift:144
#3 0x000000010d58556f in partial apply for closure #1 in SVGParser.prepareSvg(
:) ()
#4 0x000000010d553bec in thunk for @callee_guaranteed (@guaranteed XMLIndexer) -> (@error @owned Error) ()
#5 0x000000010d585594 in thunk for @callee_guaranteed (@guaranteed XMLIndexer) -> (@error @owned Error)partial apply ()
#6 0x000000010f4cda74 in Sequence.forEach(:) ()
#7 0x000000010d553ad5 in SVGParser.prepareSvg(
:) at Pods/Macaw/Source/svg/SVGParser.swift:143
#8 0x000000010d552d27 in SVGParser.parse() at Pods/Macaw/Source/svg/SVGParser.swift:128
#9 0x000000010d550b42 in static SVGParser.parse(text:) at Pods/Macaw/Source/svg/SVGParser.swift:77

meta_property-og_image.svg.zip

@amarunko
Copy link
Contributor

Hi, @zalexej, can you check on the master branch? For me, everything works as expected.

@zalexej
Copy link
Author

zalexej commented Jan 15, 2020

Mentioned SVG image works on master.
But I have some different crashes on master with another SVG images (see attached images with correspondent names).

  1. Fatal error: Unexpectedly found nil while unwrapping an Optional value: file Macaw/Source/render/NodeRenderer.swift, line 258
  2. Fatal error: Unexpectedly found nil while unwrapping an Optional value: file Macaw/Source/utils/CGMappings.swift, line 152
    svg-macaw-crashed-while-parsing.zip

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants