Drop uses of regular expressions for parsing #701
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Regular expression-based parsing is slower than the use of
Scanner
, because the latter immediately uses the information about the data it has scanned.Additionally, the current implementation crashes rarely in
NSRegularExpression.firstMatch
, which seems to be an issue with Apple's implementation. Although rare, it is noticeable.All regular expressions (
SVGParserRegexHelper
) are removed. Parsing is built uponScanner
.Also, re-parsing of XML during
<tspan>
processing is also dropped. Already existingXMLIndexer
information is processed instead. The change does not affect the current behaviour for non-embedded tspans (tspans within another tspan, which are clearly not supported by the implementation at the moment). There are no new failing tests.With the changes, SVG parsing is more efficient, shorter, a bit more resilient, has less branching and recursion, has shorter left indents. Although personally, the main reason for the minor refactoring is prevention of the rare crashes.