Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configurable capacity #8

Open
exzhawk opened this issue May 28, 2020 · 8 comments
Open

Configurable capacity #8

exzhawk opened this issue May 28, 2020 · 8 comments

Comments

@exzhawk
Copy link
Owner

exzhawk commented May 28, 2020

Allow user-defined arbitrary capacity. But still static, not in-game changeable
#7

@exzhawk
Copy link
Owner Author

exzhawk commented May 30, 2020

Plan A:
Use item meta to store capacity. Need migration for old version saves.

@Theoooooo
Copy link

This feature could be neat !
I though about it, because there is so many recipies that use a certain amount of fluid that are not available in the mod.

But i was pretty lazy to setup a Java dev environment just to add these xD

@exzhawk
Copy link
Owner Author

exzhawk commented May 31, 2020

Since making capacity configurable compatibility, a whole redo of the capacity system might be considered. Plans:

  • Configure the capacity by shift-right click an empty volumetric flask.
  • Configure the capacity of an empty volumetric flask by using a workstation.
  • Use a workstation to craft volumetric flasks with arbitary capacity. No more changes after crafted.

If capacity is fully configurable, the mechanism of the Filler has to be changed. Currently, the Filler just provides every possible volumetric flask filled in every fluid that exists in the ME network. Plans:

  • Only provided certain fluids defined by a player.
  • Only provided certain volumetric flasks defined by a player.
  • Only provided certain volumetric flasks filled with certain fluids defined by a player.

@Theoooooo
Copy link

Theoooooo commented May 31, 2020

Sounds pretty good :D
If you need help testing these future features, let le know

@exzhawk
Copy link
Owner Author

exzhawk commented May 31, 2020

But i was pretty lazy to setup a Java dev environment just to add these xD

No need to setup a dev environment if you are so sure about what to change. GitHub will do the job for you.
Just fork the repo, make your changes, commit and push to your forked repo. Head to the Actions page of your repo, click on the lastest run, and download the file under Artifacts section. Unzip the downloaded artifact and use the JAR without "sources" in the filename.
A run on Actions page might take minutes to show up.

@Theoooooo
Copy link

Uuuu i didn't knew you can do that (yes i'm using github for more than 2 years now)

i'll take a look when i got some spare time and try to do something

@Theoooooo
Copy link

Theoooooo commented Jun 7, 2020

@exzhawk
hmmm i was thinking about this and how could we plannified this behavior with applied ...
And with the filler. Something has to change with the method the mod detect empty flask inside the ME system.
Instead of displaying every craft possible with every type of liquid, the filler has to get the amount of mb define by the user and configure itself the flask befose sending it to the crafting recipe
🤔

@sgtkwol
Copy link

sgtkwol commented Nov 23, 2020

Could make a crafting recipe of 2x2 that cycles through the sizes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants