Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pydantic v2 support #206

Closed
eyurtsev opened this issue Aug 15, 2023 · 8 comments
Closed

Pydantic v2 support #206

eyurtsev opened this issue Aug 15, 2023 · 8 comments
Assignees

Comments

@eyurtsev
Copy link
Owner

  • Need to make kor pydantic v1 and v2 compatible
@codenamics
Copy link

how is it going?

@erichlin1
Copy link

@eyurtsev when do you anticipate support for pydantic v2?

@erichlin1
Copy link

@eyurtsev Thank you!

@eyurtsev
Copy link
Owner Author

eyurtsev commented Sep 6, 2023

@ericlinsd np -- not ready yet, but almost there will probably release by end of week

@eyurtsev
Copy link
Owner Author

eyurtsev commented Sep 6, 2023

Merged on main. CI tests pass with both pydantic v1 and pydantic v2 so the library is now compatible with both versions of pydantic.

@eyurtsev
Copy link
Owner Author

eyurtsev commented Sep 6, 2023

#223

@eyurtsev
Copy link
Owner Author

eyurtsev commented Sep 6, 2023

Release on pypi under version 1.0.0 -- has good unit test coverage, but let me know if there are any unexpected issues

@eyurtsev eyurtsev closed this as completed Sep 6, 2023
@surkova
Copy link

surkova commented Sep 19, 2023

There's an outstanding warning about config extra, otherwise 1.0.0 works like a charm with 2.3.0 for all I see! thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants