Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unique GUID generation test is faulty #42

Open
gekkedev opened this issue Mar 7, 2021 · 0 comments
Open

Unique GUID generation test is faulty #42

gekkedev opened this issue Mar 7, 2021 · 0 comments

Comments

@gekkedev
Copy link
Member

gekkedev commented Mar 7, 2021

expect(guids.indexOf(guids[0]) < 0).equal(false);

Essentially it just verifies the uniqueness of the first GUID. The others are not being cross-checked. Instead, it could .push() all GUIDs in a string array and check whether or not that array already .includes() the string.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant