Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tracking issue: punctuation color #240

Closed
cafkafk opened this issue Sep 10, 2023 · 4 comments
Closed

tracking issue: punctuation color #240

cafkafk opened this issue Sep 10, 2023 · 4 comments

Comments

@cafkafk
Copy link
Member

cafkafk commented Sep 10, 2023

Exa was "deprecated" last week, and this lead to an influx of users. This is
great as it has made UX issues more visible, because we now get more feedback.

On of those issues was introduced in #64, a PR where colors were changed to no
longer be "hardcoded". While not having "hardcoded" colors makes sense, we
should find some default that works for the vast majority of users.

This issue exists to track this effort.

Currently, my goal is to merge #237 before monday in time for the 0.11.1
release. If that goes out and doesn't fix it for everyone, we'll have to
further look into this.

Casued by: #64
PRs: #237
Affects: #234, #220, #208, #209

@PThorpe92
Copy link
Member

I assume u meant your goal is to merge #237 before release?

Anyone's feedback on the color change referenced in the PR would be appreciated. I did my best to find out what color your background would have to be to make these invisible... and I came up with this.

New

image

Current

@cafkafk
Copy link
Member Author

cafkafk commented Sep 10, 2023

I assume u meant your goal is to merge #237 before release?

🤦‍♀️

@smartding
Copy link

I built from the latest the commit(9372134), the new default color for punctuations is much more visible in my color setting now:

New color:
image

@cafkafk
Copy link
Member Author

cafkafk commented Sep 12, 2023

Closed as fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants