Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Break functionality into sub-libraries #1

Open
ezkl opened this issue Feb 29, 2012 · 3 comments
Open

Break functionality into sub-libraries #1

ezkl opened this issue Feb 29, 2012 · 3 comments
Labels
Milestone

Comments

@ezkl
Copy link
Owner

ezkl commented Feb 29, 2012

Thinking about breaking each sniffing "pattern" into individual modules; i.e. sniffles-wordpress or sniffles-jquery. The base module would provide the parsers and query methods for common HTML nodes. Thinking mostly about making it easy to extend.

Any feedback on this kind of design @JakeAustwick and @dchuk?

@JakeAustwick
Copy link

I like this idea, it makes things much more organised and easier / cleaner to add new modules / patterns. I say go for it.

@JakeAustwick
Copy link

I'm not sure on the best way to structure this, I've never really built something using a sub-module typed structure as you suggest, I'm still fairly new to Ruby, so I'll let you handle this. But once this is implemented I'll be more than happy to extend this project with a number of detection methods for common CMS's and scripts, as me and @dchuk have a use for this.

@ezkl
Copy link
Owner Author

ezkl commented Mar 3, 2012

Before making this sort of structural change, I'd like to focus on adding better sniffer definition to the core library API. I made the first major step with v0.1.0. I've broken sniffers into individual classes under categorized sub-directories in the main repository. Hopefully this will make adding more sniffers easier for everyone while we figure out how to improve the API.

All of that said, sub-libraries are sounding better and better.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants