Skip to content

Commit e8f59ef

Browse files
authored
fix: don't error out while catching a buildStart error (#422)
- per in-line comment, if an error occurs during `buildStart` initialization, then the `cache` may not exist yet during `buildDone` - since we now use `context.error` instead of `throw` during initialization (from the `options` -> `buildStart` change), `buildEnd` will run during initialization - and the `cache` var is initialized in `buildStart` as well, so if an error occurs before then, the `cache` won't exist - we should gracefully handle this in all cases, since it's possible that even creating the `cache` could throw an error - this error was hiding the underlying error, which was problematic for DX as well as bug reports (see my issue follow-up) - add an integration test for `tsconfig` to make sure this code works - while this is similar to the previous `tsconfig` integration tests (that were moved to unit tests), this covers all cases of `buildStart` errors, and is not specific to the different `tsconfig` errors (unlike the unit tests) - this test will fail without the source code changes in this commit
1 parent 0b99f8e commit e8f59ef

File tree

2 files changed

+8
-1
lines changed

2 files changed

+8
-1
lines changed

__tests__/integration/errors.spec.ts

+7
Original file line numberDiff line numberDiff line change
@@ -88,3 +88,10 @@ test("integration - type-only import error - abortOnError: false / check: false"
8888
expect(output.length).toEqual(files.length); // no other files
8989
expect(onwarn).toBeCalledTimes(1);
9090
});
91+
92+
// integration test variant of parse-tsconfig unit test, to test how other hooks interact with an error thrown in buildStart
93+
test("integration - tsconfig error", async () => {
94+
await expect(genBundle("semantic.ts", {
95+
tsconfigOverride: { compilerOptions: { module: "none" } },
96+
})).rejects.toThrow("Incompatible tsconfig option. Module resolves to 'None'. This is incompatible with Rollup, please use");
97+
});

src/index.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -79,7 +79,7 @@ const typescript: PluginImpl<RPT2Options> = (options) =>
7979
if (!watchMode && !noErrors)
8080
context.info(yellow("there were errors or warnings."));
8181

82-
cache.done();
82+
cache?.done(); // if there's an initialization error in `buildStart`, such as a `tsconfig` error, the cache may not exist yet
8383
}
8484

8585
const pluginOptions: IOptions = Object.assign({},

0 commit comments

Comments
 (0)