Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sourcemap in Vite dev mode with pnpm is incorrect #294

Closed
agileago opened this issue Dec 17, 2021 · 2 comments
Closed

sourcemap in Vite dev mode with pnpm is incorrect #294

agileago opened this issue Dec 17, 2021 · 2 comments
Labels
problem: needs more info This issue needs more information in order to handle it problem: removed issue template OP removed the issue template without good cause problem: stale Issue has not been responded to in some time scope: integration Related to an integration, not necessarily to core (but could influence core) scope: Vite Related to integration with Vite, not Rollup, which this plugin was designed for solution: unresolved Issue has been closed by OP but root cause has not necessarily been resolved

Comments

@agileago
Copy link

What happens and why it is wrong

Environment

as a vite plugin to develop

Versions

latest

repo: clone https://github.com/agileago/vue3-oop

pnpm install
pnpm run dev

you will see count.service.ts sourcemap is not right and can't breakpoint . but when you change vite.config.ts to use @rollup/plugin-typescript . it is ok. because @rollup/plugin-typescript is too slow. by the way. because i use decorator so i need typescript compile not esbuild

@lake2

This comment was marked as duplicate.

@agilgur5 agilgur5 changed the title support sourcemap in vite dev mode sourcemap in Vite dev mode with pnpm and aliases is incorrect Jun 8, 2022
@agilgur5 agilgur5 added the problem: removed issue template OP removed the issue template without good cause label Jun 8, 2022
@agilgur5
Copy link
Collaborator

agilgur5 commented Jun 8, 2022

Since OP did not link a permalink, I had to find an old git tag myself in their repo to find the code. I also can't read the language it's written in (Chinese I assume? based on the alphabet and Vue's popularity there)

There's a confounding issue here with pnpm that may be the cause but it's hard to tell with a complicated repo like that. A minimal reproduction would be very helpful, see the repro environment here.
If you were using any symlinks with pnpm, you may have hit #234. That was recently fixed in #332 and released in 0.32.0

@agilgur5 agilgur5 added the solution: unresolved Issue has been closed by OP but root cause has not necessarily been resolved label Jun 8, 2022
@agilgur5 agilgur5 changed the title sourcemap in Vite dev mode with pnpm and aliases is incorrect sourcemap in Vite dev mode with pnpm is incorrect Jun 8, 2022
@agilgur5 agilgur5 added the problem: stale Issue has not been responded to in some time label Jun 29, 2022
@agilgur5 agilgur5 added scope: integration Related to an integration, not necessarily to core (but could influence core) problem: needs more info This issue needs more information in order to handle it and removed problem: needs more info This issue needs more information in order to handle it labels Jul 30, 2022
@agilgur5 agilgur5 added the scope: Vite Related to integration with Vite, not Rollup, which this plugin was designed for label Mar 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
problem: needs more info This issue needs more information in order to handle it problem: removed issue template OP removed the issue template without good cause problem: stale Issue has not been responded to in some time scope: integration Related to an integration, not necessarily to core (but could influence core) scope: Vite Related to integration with Vite, not Rollup, which this plugin was designed for solution: unresolved Issue has been closed by OP but root cause has not necessarily been resolved
Projects
None yet
Development

No branches or pull requests

3 participants