Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature request: stack on an already submitted PR #17

Closed
zasdfgbnm opened this issue Mar 27, 2020 · 3 comments
Closed

Feature request: stack on an already submitted PR #17

zasdfgbnm opened this issue Mar 27, 2020 · 3 comments

Comments

@zasdfgbnm
Copy link

Sometimes I realize I should use stacked diff only after I have already submitted one. It would be good if I can still do a stacked diff, but the base is on a submitted PR.
@ezyang
Copy link
Owner

ezyang commented Apr 1, 2020

Yeah, this will be kind of tricky to implement, because ghstack assumes that all diffs have uniform branch format and so if there is an old fashioned PR already it would violate this. Plus, if you submitted your PR in your fork, you are SOL, we cannot implement this at all. My fix for this is to just use ghstack for everything (lol).

@zasdfgbnm
Copy link
Author

My fix for this is to just use ghstack for everything (lol).

That is actually a good suggestion!

@ezyang
Copy link
Owner

ezyang commented Dec 2, 2023

Would be subsumed by #122

@ezyang ezyang closed this as not planned Won't fix, can't repro, duplicate, stale Dec 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ezyang @zasdfgbnm