disconnect SLOT(handleChannelMessageQueue)

[srcejon]

In afc.cpp and and demodanalyzer.cpp we have:

            disconnect(messageQueue, SIGNAL(messageEnqueued()), this, SLOT(handleChannelMessageQueue(MessageQueue*)));

However, I don't think this will work as intended, as a lambda is what is connected to, not handleChannelMessageQueue:

            QObject::connect(
                messageQueue,
                &MessageQueue::messageEnqueued,
                this,
                [=](){ this->handleChannelMessageQueue(messageQueue); },
                Qt::QueuedConnection
            );

If c++ syntax is used for the disconnect, it fails to compile.

Should be able to disconnect everything by passing nullptr instead, or I think need to save the return value from connect and use that for the disconnect.

edit: Just realised this is the same type of problem as #1620

[f4exb]

Yes to disconnect a connect done with a lambda one should use nullptr for the slot reference. This is not very obvious and I discovered it in #1620 indeed.