ATV modulator no longer available in Windows build

[pa3byv]

Hi, we are still using v6.16 in Windows 10 because it has an ATV modulator. It seems to have disappeared from Windows builds in V7, probably from V6.20 onwards. But I see it is still maintained and available in the Linux builds. Is there a special reason for this and if not could you please include it in the V7 Windows build again?

Many thanks,
Poll

[srcejon]

From the github action log, I see:

Not building modatv (ENABLE_CHANNELTX_MODATV=ON OpenCV_FOUND=0)

I think this is probably due to the version of OpenCV in sdrangelwindowslibraries not working with the latest version of Visual C. Updating to 4.10 seems to work.

[pa3byv]

Thanks for looking into it. Hopefully the ATV module will reappear in the next build then.

[srcejon]

@f4exb have submitted a PR to sdrangel-windows-library

We'll also need a small update in CMakeLists.txt

if(VS2019)
    set(OpenCV_DIR "${EXTERNAL_LIBRARY_FOLDER}/opencv4" CACHE INTERNAL "")

Should be VS2019 OR VS2022

[0x0V3RF10W]

Hello! Any plans to return modatv to windows builds?

[srcejon]

@f4exb - unfortunately need a small patch to the opencv cmakefiles: f4exb/sdrangel-windows-libraries#26

[srcejon]

Hello! Any plans to return modatv to windows builds?

Hopefully should be in the next release.

[srcejon]

Back in 7.22.1

[pa3byv]

Thanks very much!On 11 Oct 2024, at 14:38, srcejon ***@***.***> wrote: Back in 7.22.1 —Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you authored the thread.Message ID: ***@***.***>