Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DATV Demod can crash SDRangel when closed #827

Closed
srcejon opened this issue Mar 31, 2021 · 1 comment
Closed

DATV Demod can crash SDRangel when closed #827

srcejon opened this issue Mar 31, 2021 · 1 comment
Labels
Milestone

Comments

@srcejon
Copy link
Collaborator

srcejon commented Mar 31, 2021

In SDRangel 6.7.0, if you close the DATV Demod channel, SDRangel can sometimes crash.

2021-03-31 20:53:33.653 (D) DATVDemod::~DATVDemod
2021-03-31 20:53:33.653 (D) DSPDeviceSourceEngine::removeSink: DATVDemod
2021-03-31 20:53:33.653 (D) DSPDeviceSourceEngine::handleSynchronousMessages: DSPRemoveBasebandSampleSink
--Type for more, q to quit, c to continue without paging--

Thread 1 "sdrangel" received signal SIGSEGV, Segmentation fault.
0x0000000000000000 in ?? ()
(gdb) up
#1 0x00007fffb6b885bf in DATVDemodGUI::~DATVDemodGUI (this=, this=)
at /opt/build/srcejon/sdrangel/plugins/channelrx/demoddatv/datvdemodgui.cpp:271
271 m_objDATVDemod->stop();

Have seen it happen on both Windows and Linux.

@f4exb f4exb added the bug label Apr 1, 2021
@f4exb
Copy link
Owner

f4exb commented Apr 1, 2021

m_objDATVDemod->stop(); should not be called in GUI destructor because this is already invoked in ~DATVDemod

@f4exb f4exb closed this as completed in 3d108d2 Apr 1, 2021
@f4exb f4exb added this to the v6.7.1 milestone Apr 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants