Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

telegram plugin is changing the config which causes interface reloads #156

Closed
Mirarkitty opened this issue Dec 18, 2018 · 2 comments
Closed

Comments

@Mirarkitty
Copy link

The telegram plugin is changing the config,

-rw-rw-r-- 1 pi pi 4579 Dec 18 06:21 config.yaml
-rw-r--r-- 1 pi pi 4579 Dec 17 21:18 config.yaml.bup
pi@octopi:~/.octoprint$ diff config.yaml config.yaml.bup 
143c143
<         image: /plugin/telegram/img/user/pic75232830.jpg?1545114108170
---
>         image: /plugin/telegram/img/user/pic75232830.jpg?1545065971005

This change to config.yaml is propagating to the interface, which then is forcing a reload of the interface because of a new config hash. See
OctoPrint/OctoPrint#2950

@foosel
Copy link
Contributor

foosel commented Dec 18, 2018

As a side note, the settings are really the wrong place to store volatile data (e.g. a constantly changing URL with a cache buster). I'd rather suggest to only store the base path and then apply the cache buster in JS.

@Mirarkitty
Copy link
Author

Mirarkitty commented Feb 7, 2019

Just removing the part that adds "?"+time works to solve the immediate issue, and doesn't seem to cause any other issues (images are still perfectly fine and updated in Telegram).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants