Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Overrides selection of text? #79

Closed
dgkimpton opened this issue Jun 30, 2021 · 4 comments
Closed

Overrides selection of text? #79

dgkimpton opened this issue Jun 30, 2021 · 4 comments

Comments

@dgkimpton
Copy link

As far as I can tell using this extension overrides the selectionBackground colour so that it is impossible to see which text is currently selected within a TODO (or other highlighted block).

Would it be possible to make this highlighting have lower precedence than selected text?

@noisnemid
Copy link

Reference merely.

I am not the developer of this extension but I think it'll be a little complicated and there could be an alternative thing which you need some tests.

VSCode itself in fact has some settings items to control the selection background color, but they are not listed in API docs.

as the example shows, you could find some information here microsoft/vscode#34105

"workbench.colorCustomizations": {
        //     "ref": "https://github.com/Microsoft/vscode/issues/34105",
        "editor.background": "#000000",
        // "editor.foreground": "#FFFFFF",
        //     "editor.lineHighlightBackground": "#000000",
        //     "editor.selectionHighlightBackground": "#FF000088",
        "editor.findMatchBackground": "#FF000088",
        "editor.findMatchHighlightBackground": "#e0a607",
        //     "editor.findRangeHighlightBackground": "#00000088",
        //     "editor.selectionBackground": "#30303088",
        //     "editor.inactiveSelectionBackground": "#30303088",
        "editorGutter.background": "#0845c91a"
    },

uncomment some lines to see the real effects, and maybe you can find what you are expecting.

@dgkimpton
Copy link
Author

Sadly I'm already aware of them, but they didn't help. However, I did find a workaround which is to change the Highlight colours (e.g. for TODO) to have an alpha component of about 50%. In this way, I can still see the selection showing through. It's not absolutely ideal but it is workable... which is by far the main thing :)

@ghost
Copy link

ghost commented Nov 24, 2021

To necrobump this: IMHO it is always a good idea to work with extremely low alpha values for backgrounds, as they will blend in better with your selected color theme. You can still color the # TODO via first decoration in an more extreme fashion (also: the overViewRulerColor might help). But ultimately it's a matter of taste of course

2021-11-24_11-34-17_@443,87+435x842
2021-11-24_11-34-50_@447,599+426x335

@fabiospampinato
Copy link
Owner

Nice suggestions.

@qodo-io I like your setup!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants