Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recycle=true not recycling #63

Open
Marcel0024 opened this issue Dec 18, 2021 · 3 comments
Open

Recycle=true not recycling #63

Marcel0024 opened this issue Dec 18, 2021 · 3 comments

Comments

@Marcel0024
Copy link

Marcel0024 commented Dec 18, 2021

I have these two terminals:

{
  "autorun": true,
  "autokill": true,
  "terminals": [
     {
        "name": "npm start",
        "command": "npm start",
        "recycle": true
      },
      {
        "name": "npm test",
        "command": "npm test -- --coverage --watch-all",
        "recycle": true
      }
  ]
}

After restarting VS code, it just makes new terminals:
image

Expected behaviour
when using recycle: true the old terminals will be reused and not create a new one

@gbny
Copy link

gbny commented Jan 25, 2022

I fixed this by disabling Persistent Session Revive in settings:

In VSCode settings ( Ctrl+, ) :
Filter for "@feature:terminal Persistent Session Revive Process" and set it to "never".
This prevents VSCode from opening duplicate sets of terminals on application launch.

Now my currently open Terminals Manager terminals recycle properly on application launch :)

@Marcel0024
Copy link
Author

@gbny

Nice! thanks that works. Maybe it should be documented.

@simensol
Copy link

simensol commented Apr 11, 2022

@gbny's workaround doesn't work when I use VSC's developer container, even when persistent bash history is enabled.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants