Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Potential Improvement: Darker syntax highlight colors for light themes #204

Closed
sahil48 opened this issue Jun 7, 2019 · 1 comment
Closed

Potential Improvement: Darker syntax highlight colors for light themes #204

sahil48 opened this issue Jun 7, 2019 · 1 comment

Comments

@sahil48
Copy link

sahil48 commented Jun 7, 2019

The syntax highlighting for todo-plus taskpaper documents looks great in dark theme. Colors selected for most light themes I have tried are too bright, with very little contrast, as shown below. Improvements to this would be much appreciated.

image
@sahil48 sahil48 changed the title Better syntax highlight colors for light themes Better syntax highlight colors for light themes Needed Jun 7, 2019
@sahil48 sahil48 changed the title Better syntax highlight colors for light themes Needed Potential Improvement: Darker syntax highlight colors for light themes Jun 7, 2019
@fabiospampinato
Copy link
Owner

This is unimplementable currently: microsoft/vscode#32813

We could pick some default colors for light themes, but IMHO those would never look perfect until the linked issue gets addressed.

Duplicate of #21.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@fabiospampinato @sahil48