Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"todo.embedded.view.sort": "label" does not work as expected #370

Open
nazmulidris opened this issue Mar 14, 2023 · 3 comments
Open

"todo.embedded.view.sort": "label" does not work as expected #370

nazmulidris opened this issue Mar 14, 2023 · 3 comments
Labels

Comments

@nazmulidris
Copy link

Repro step

  1. Edit vscode settings.json
  2. Add a key/value pair of: "todo.embedded.view.sort": "label",
  3. Add some todo items like: // TODO: 1. foo at the bottom of a file, // TODO: 2. bar at the top of a file

Observed vs expected behavior

  1. The embedded todo views will show the todos in line order and not label sort order, which is what I was expected having set todo.embedded.view.sort to label.
    1. I was expecting TODO: 1. foo to be at the top of the todo embedded view and TODO: 2. bar to be at the bottom.
    2. But it was the opposite (which is what the result should be if sort order is line).
  2. It looks like https://github.com/fabiospampinato/vscode-todo-plus/blob/master/src/views/embedded.ts#L80 is probably doing the right thing, so I'm not sure what is going on to cause this issue 🤔.

Debugging attempt

I thought maybe the todo.embedded.provider was impacting this somehow. My default is set to rg, so I changed it to javascript and observed the same behavior. So changing the provider doesn't seem to have any impact.

@fabiospampinato
Copy link
Owner

Can you post a screenshot of the result so that we are exactly on the same page?

@nazmulidris
Copy link
Author

Can you post a screenshot of the result so that we are exactly on the same page?

image

@fabiospampinato
Copy link
Owner

Ok that doesn't look right 🤔

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants