Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JSON parsing error handling #251

Closed
oscgonfer opened this issue Sep 21, 2023 · 2 comments
Closed

JSON parsing error handling #251

oscgonfer opened this issue Sep 21, 2023 · 2 comments
Assignees
@timcowlishaw
Milestone
0723

Comments

@oscgonfer
Copy link
Contributor

Improve JSON parsing error handling and logging in case of corrupt JSON payloads from MQTT:

https://github.com/fablabbcn/smartcitizen-api/blob/master/app/lib/mqtt_messages_handler.rb#L23
@oscgonfer oscgonfer mentioned this issue Sep 21, 2023
Open
@sentry-io
Copy link

sentry-io bot commented Sep 22, 2023

Sentry issue: SC-API-B7

@oscgonfer oscgonfer added this to the 1223 milestone Sep 22, 2023
@timcowlishaw timcowlishaw mentioned this issue Oct 5, 2023
Merged
@oscgonfer oscgonfer modified the milestones: 1223 (refactor), 0723 Oct 10, 2023
@oscgonfer
Copy link
Contributor Author

This error comes from invalid unicode characters sent by the device - normally from an old firmware version. We are thinking to add a better user feedback, so that they can update the firmware and we are tracking this on #288 and #238

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@timcowlishaw timcowlishaw

Labels
None yet
Projects
None yet
Milestone
0723
Development

No branches or pull requests
2 participants
@timcowlishaw @oscgonfer