Add TimeSpan.Parse and TimeSpan.TryParse support to Python
#3645
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MangelMaxime
force-pushed
the
timespan_parse_try_parse
branch
from
c1b7e74 to
f08bf91
Compare
dbrattli
reviewed
Dec 8, 2023
| raise Exception("String '%s' was not recognized as a valid TimeSpan." % string) | ||
|
|
||
|
|
||
| def try_parse(string: str, def_value_or_format_provider: FSharpRef[TimeSpan] | Any, def_value : FSharpRef[TimeSpan] | None = None) -> bool: |
There was a problem hiding this comment.
Missing format (line too long)
dbrattli
reviewed
Dec 8, 2023
dbrattli
reviewed
Dec 8, 2023
dbrattli
reviewed
Dec 8, 2023
dbrattli
reviewed
Dec 8, 2023
dbrattli
reviewed
Dec 8, 2023
|
@dbrattli Thanks you for the review. I added ruff format to the git hooks, so now we should have the python code auto formatted before commit to avoid dealing with it manually. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The tests have been ported from the JavaScript implementation, there are some still marked as todo like in the JavaScript implementation didn't look at why there is a todo yet.
The only test that is different is one that is marked as not passing on JavaScript, than pass with our Python implementation. I believe this is related to the fact that we have a better precision in our Python implementation.