Fable 1 support

[forki]

subsumes #19

[alfonsogarciacaro]

Ok, I close #19 👍 Things to do:

• Check if everything works removing the Pojo attribute
• Update Fable and libraries to 1.1.x (with Fable.Import.Browser split)
• Fix build script

[forki]

I'm working on the build

[forki]

@alfonsogarciacaro what now?

[forki]

@alfonsogarciacaro how is it supposed to work now?

[alfonsogarciacaro]

@forki I was just running Fable/Rollup and React Native in two different terminals:

#Terminal 1
dotnet fable npm-run build

#Terminal 2
react-native run-android

Remember to restore dependencies first :)

[forki]

run fableTool "--verbose --symbols PRODUCTION" ""

how would this look like?

[alfonsogarciacaro]

In Fable 1.0 it's the fable-loader which sends the symbols/defineconstants to the Fable daemon. The tricky part is Webpack won't accept custom arguments (I think). Right now what we usually do is to detect if the -p argument has been passed to Webpack, and then pass the appropriate define symbols for each case. But I'm not sure with Rollup, I'll check.

The --verbose argument can be passed normally: dotnet fable npm-run build --verbose. See: dotnet fable --help for details.

[forki]

good but I need to pass compiler directives as well

[alfonsogarciacaro]

Yes, you need to do it from the webpack.config.js (rollup.config.js in this case). It's not possible to pass compiler directives directly to Fable daemon because in theory the same daemon can be used to compile multiple projects with different configurations.

Anyways, don't worry, I'll do it later 👍

[forki]

seems calling yarn install hangs for me

[forki]

yarn install v0.23.2

[alfonsogarciacaro]

Bad karma ;) Maybe try updating yarn or use npm 5 (npm install -g npm to update)

[alfonsogarciacaro]

I've made some changes in #19, maybe you can rebase/merge them to this PR?

• Update to Fable 1.1.3
• Remove Pojo attribute
• Detect if it's a production build in Rollup config (when you don't pass the -w argument) and in that case pass the PRODUCTION compiler directive to Fable). I've also changed the name of package.json script to start (watch/development) and build (production) to match other Fable templates 👍

[alfonsogarciacaro]

Apparently the latest commits are not showing in #19 PR as it's closed, you need to check branch fable-1-1 directly.

[forki]

[forki]

wtf? stying like this forever

[forki]

running chcp 850 resolved it

[forki]

@alfonsogarciacaro now I'm lost:

[inosik]

@forki I think I ran into this once, when I tried to fix fsprojects/FAKE#1461, at least I had the same stack trace.

Node.js seems to have a problem with the Console.OutputEncoding change we do in FAKE to prevent the Chinese characters bug on Mono.

Does the build script output any Unicode characters? I triggered this crash when printing the copyright character to the console.

[forki]

./node_modules/.bin/react-native run-android doesn't work
.\node_modules\.bin\react-native run-android doesn't work

react-native.cmd run-android does work a bit further:

 A problem occurred configuring project ':react-native-onesignal'.

which is probably a real error

[alfonsogarciacaro]

For the record, in my tests I was using the react-native command installed globally (by running npm i -g react-native-cli) as this is what the React Native tutorial recommends.

[forki]

crazy! I got it working. Only one issue: Fable doesn't go to watch mode. Ideas?

[inosik]

Call dotnet fable npm-run start instead of ... build from FAKE?

[forki]

ok that works. Fable is in watch mode and runs on device.

two remaining issue:

a) ionide is unhappy and show lots of errors /cc @Krzysztof-Cieslak
b) for normal build we need to set production flag for compiler directive

[inosik]

You can revert 94fffb5.

[enricosada]

@forki atm ionide and fsac and sdk are solid :D

dotnt build

       "e:\github\fable-react_native-demo\Nightwatch.fsproj" (Build target) (1) ->
       (CoreCompile target) ->
         C:\dotnetcli\dotnet-dev-win-x64.1.0.4\sdk\1.0.4\Sdks\FSharp.NET.Sdk\Sdk\Sdk.targets(27,5): warning : The 'CoreCompile' target should be overriden in 'FSharp.NET.Sdk' package. Maybe you need to add 'FSharp.NET.Sdk' package to fsproj or run restore [e:\github\fable-react_native-demo\Nightwatch.fsproj]

after adding <PackageReference Include="FSharp.NET.Sdk" Version="1.0.*" /> works

gif is wip of new restore if not already + progress indicators for that (at end more restore asked, because fable doesnt do project references to these otherwise np, i'll take that in consideration too for ionide)

[forki]

ok ionide fixed with help of @enricosada and @Krzysztof-Cieslak

[forki]

so last thing on the list: compiler directives

[forki]

ok compiler directives work as well. yay!

one last thing:

let result =
    ExecProcess (fun info ->
        info.FileName <- dotnetExePath
        info.WorkingDirectory <- srcDir
        info.Arguments <- " fable npm-run build") TimeSpan.MaxValue
if result <> 0 then failwith "fable shut down."

it seems that a compiler error doesn't make this quit with exit code <> 0 - therefor build continues.

@alfonsogarciacaro ideas?

[alfonsogarciacaro]

This is tricky. Before Fable 1.0, compilation would stop after encountering the first error. I changed this so you could get multiple errors and show them in the IDE (see here). For bundler it's also important not to stop compilation, because then file dependencies won't be listed and thus won't be watched for changes either.

I think this is working fine with Webpack, but Rollup had a problem because errors would stop compilation so I had to report everything as a warning.

Probably we can work around this by adding a failOnError option or similar to the Rollup plugin to throw actual errors if it's not a watch compilation, what do you think?

[forki]

yes I only need to let it fail on "normal" build withoutt watch, But we need to make it so otherwise CI would just go on and create corrupt apk

[alfonsogarciacaro]

I've publish rollup-plugin-fable 1.0.6, can you please update and change this line as follows?

  plugins: [fable({extra: { failOnError: true })],

[forki]

seems to work! thx

[forki]

wow Fable 1 is now working on my device as expected!!!!

Thanks so much everyone