Fix a bug in AnimatedExpansion #119
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ent ref exists Fixes an error 'Argument of type 'null' is not assignable to parameter of type 'HTMLElement'.
pearofducks
approved these changes
Jun 8, 2022
|
🎉 This PR is included in version 1.2.0-next.4 🎉 The release is available on: Your semantic-release bot 📦🚀 |
BalbinaK
added a commit
that referenced
this pull request
Jun 8, 2022
* feat(packages): add inline Alert component (#106) Add inline alert component to feedback indicators based on Figma sketches: https://www.figma.com/file/gpHv46zswMNeepUDyQfpS8/Feedback-indicators?node-id=274%3A31588 ### Features * **packages:** add inline Alert component ([#106](#106)) ([ddfe084](ddfe084)) * docs: don't disable button on modal * feat(alert): add expand and collapse behaviour to inline alert (#114) * refactor(expandable): extract transition animation from Expandable Create AnimatedExpansion component that handles expand-collapse animation in Expandable, making it possible to easily add this behaviour to other components. * feat(alert): add expansion and collapsion behaviour to inline alert Wrap Alert in AnimatedExpansion component to make it appear and disappear smoothly * feat(alert): remove neutral variant of inline alert * **alert:** add expand and collapse behaviour to inline alert ([#114](#114)) ([075f314](075f314)) * fix(affix): Add aria-label to Affix icons Screen readers will use the aria-label on the SVG only if the button wrapper has no label. So in that sense, these default labels are like fallbacks. * chore(release): 1.2.0-next.3 [skip ci] # [1.2.0-next.3](v1.2.0-next.2...v1.2.0-next.3) (2022-06-07) ### Bug Fixes * **affix:** Add aria-label to Affix icons ([17fab00](17fab00)) * fix: bump component-classes to get Step fix * chore(deps): change to css/component-classes * fix(animated-expansion): rename to ExpandTransition and check if element ref exists (#119) Fixes an error 'Argument of type 'null' is not assignable to parameter of type 'HTMLElement'. * chore(release): 1.2.0-next.4 [skip ci] # [1.2.0-next.4](v1.2.0-next.3...v1.2.0-next.4) (2022-06-08) ### Bug Fixes * **animated-expansion:** rename to ExpandTransition and check if element ref exists ([#119](#119)) ([b7a8026](b7a8026)) * bump component-classes to get Step fix ([5d99506](5d99506)) * chore(release): 1.2.0-next.5 [skip ci] # [1.2.0-next.5](v1.2.0-next.4...v1.2.0-next.5) (2022-06-08) ### Bug Fixes * bump component-classes to get Step fix ([c17ce7e](c17ce7e)) Co-authored-by: semantic-release-bot <semantic-release-bot@martynus.net> Co-authored-by: Richard Walker <digitalsadhu@gmail.com> Co-authored-by: Martin Storsletten <martin.storsletten@finn.no> Co-authored-by: Benjamin Akar <benjaminakar2001@gmail.com> Co-authored-by: Dave Honneffer <pearofducks@gmail.com>
github-actions bot
pushed a commit
that referenced
this pull request
Jun 8, 2022
# [1.2.0](v1.1.1...v1.2.0) (2022-06-08) ### Bug Fixes * **affix:** Add aria-label to Affix icons ([17fab00](17fab00)) * **animated-expansion:** rename to ExpandTransition and check if element ref exists ([#119](#119)) ([b7a8026](b7a8026)) * bump component-classes to get Step fix ([5d99506](5d99506)) * bump component-classes to get Step fix ([c17ce7e](c17ce7e)) ### Features * **alert:** add expand and collapse behaviour to inline alert ([#114](#114)) ([075f314](075f314)) * **packages:** add inline Alert component ([#106](#106)) ([ddfe084](ddfe084)) ### Reverts * Revert "Release from next to main (#120)" (#121) ([04a1976](04a1976)), closes [#120](#120) [#121](#121)
|
🎉 This PR is included in version 1.2.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds a check if
expandableRef.currentexists, which fixes a TS errorArgument of type 'null' is not assignable to parameter of type 'HTMLElement'.Additionally
Renames component from
AnimatedExpansiontoExpandTransitionto align the naming with other packages (Vue and Elements)Tests
AlertandExpandablework as before