Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(alert): type 'role' prop as optional #148

Merged
merged 1 commit into from
Sep 14, 2022
Merged

Conversation

BalbinaK
Copy link
Contributor

role prop of Alert component has a default value so it shouldn't be required.

@BalbinaK BalbinaK requested a review from a team September 14, 2022 12:13
Copy link
Contributor

@pearofducks pearofducks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@BalbinaK
Copy link
Contributor Author

@BalbinaK BalbinaK merged commit 895e69c into next Sep 14, 2022
@pearofducks
Copy link
Contributor

@BalbinaK - "?" was a joke, since all this PR did was add a question mark ;)

@BalbinaK BalbinaK deleted the bugfix/alert-props branch September 14, 2022 12:46
github-actions bot pushed a commit that referenced this pull request Sep 14, 2022
# [1.4.0-next.12](v1.4.0-next.11...v1.4.0-next.12) (2022-09-14)

### Bug Fixes

* **alert:** type 'role' prop as optional ([#148](#148)) ([895e69c](895e69c))
@github-actions
Copy link
Contributor

🎉 This PR is included in version 1.4.0-next.12 🎉

The release is available on:

Your semantic-release bot 📦🚀

@BalbinaK
Copy link
Contributor Author

BalbinaK commented Sep 14, 2022

@pearofducks

github-actions bot pushed a commit that referenced this pull request Sep 20, 2022
## [1.4.1-next.1](v1.4.0...v1.4.1-next.1) (2022-09-20)

### Bug Fixes

* **alert:** type 'role' prop as optional ([#148](#148)) ([895e69c](895e69c))
* **expandable:** set button type to 'button' to prevent default submit behaviour ([#147](#147)) ([cadeafe](cadeafe))
* remove additional hidden label ([545e7f8](545e7f8))
@github-actions
Copy link
Contributor

🎉 This PR is included in version 1.4.1-next.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

github-actions bot pushed a commit that referenced this pull request Sep 21, 2022
## [1.4.1](v1.4.0...v1.4.1) (2022-09-21)

### Bug Fixes

* **alert:** type 'role' prop as optional ([#148](#148)) ([895e69c](895e69c))
* **expandable:** set button type to 'button' to prevent default submit behaviour ([#147](#147)) ([cadeafe](cadeafe))
* remove additional hidden label ([545e7f8](545e7f8))
@github-actions
Copy link
Contributor

🎉 This PR is included in version 1.4.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants