feat(toggle): handle indeterminate state in a select-all checkbox #161
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add support for displaying a checkbox with a small dash instead of a tick to indicate that the option is not exactly checked or unchecked. q
Check if input value (selected or checked) is defined to determine whether input is controlled.
BalbinaK
requested review from
pearofducks,
digitalsadhu,
benja,
martin-storsletten and
adidick
benja
reviewed
Oct 31, 2022
benja
reviewed
Nov 2, 2022
BalbinaK
deleted the
FRON-680-react-toggle-indeterminant-mixed-state-in-the-select-all-checkbox
branch
github-actions bot
pushed a commit
that referenced
this pull request
Nov 3, 2022
# [1.5.0-next.1](v1.4.3-next.1...v1.5.0-next.1) (2022-11-03) ### Features * **toggle:** handle indeterminate state in a select-all checkbox ([#161](#161)) ([af1970b](af1970b))
|
🎉 This PR is included in version 1.5.0-next.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
github-actions bot
pushed a commit
that referenced
this pull request
Nov 21, 2022
# [1.5.0](v1.4.2...v1.5.0) (2022-11-21) ### Bug Fixes * **breadcrumbs:** handle array of nodes passed as children ([04728d9](04728d9)) * **Card:** fix toggle-in-card navigation ([#165](#165)) ([fd03fc6](fd03fc6)) ### Features * **toggle:** handle indeterminate state in a select-all checkbox ([#161](#161)) ([af1970b](af1970b))
|
🎉 This PR is included in version 1.5.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes fabric-ds/issues#110 / FRON-680
Additionally: fix a React input error where we were trying to control an uncontrolled input value.