New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Standardize how AB is enabled/disabled #4

Open

rafabene opened this issue Sep 26, 2017 · 2 comments

rafabene commented Sep 26, 2017

To disable AB in https://hub.docker.com/r/fabric8/java-jboss-openjdk8-jdk/ the env var is AB_OFF
To disable AB in https://hub.docker.com/r/fabric8/s2i-java/ the env var is AB_JOLOKIA_OFF

Contributor

rhuss commented Sep 27, 2017

Actually, the origin of this comes from https://github.com/fabric8io/agent-bond/blob/master/fish-pepper/agent-bond/readme.md it these variables server different purposes:

AB_OFF is to switch off Agent-Bond completely (Jolokia and Prometheus)
AB_JOLOKIA_OFF switches off only Jolokia

Since s2i only supports Jolokia, only the latter part is used. For the full image you can use both variables (which means also AB_JOLOKIA_OFF)

Contributor

rhuss commented Sep 27, 2017

Sorry, I was wrong. There is no AB_JOLOKIA_OFF in the standard image.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment