Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SaveMojo] create the savedir for explictl targets #1013

Merged
merged 1 commit into from
Apr 25, 2018

Conversation

t-8ch
Copy link
Contributor

@t-8ch t-8ch commented Apr 25, 2018

docker:save will now also create the target directory when a saveFile has been
configured explicitly. Before this was only the case when the target
(directory) as computed automatically.

Signed-off-by: Thomas Weißschuh thomas.weissschuh@de.amadeus.com

docker:save will now also create the target directory when a saveFile has been
configured explicitly. Before this was only the case when the target
(directory) as computed automatically.

Signed-off-by: Thomas Weißschuh <thomas.weissschuh@de.amadeus.com>
@codecov
Copy link

codecov bot commented Apr 25, 2018

Codecov Report

Merging #1013 into master will not change coverage.
The diff coverage is 0%.

@@           Coverage Diff            @@
##             master   #1013   +/-   ##
========================================
  Coverage      51.8%   51.8%           
  Complexity     1365    1365           
========================================
  Files           147     147           
  Lines          7460    7460           
  Branches       1132    1132           
========================================
  Hits           3865    3865           
  Misses         3229    3229           
  Partials        366     366
Impacted Files Coverage Δ Complexity Δ
...rc/main/java/io/fabric8/maven/docker/SaveMojo.java 0% <0%> (ø) 0 <0> (ø) ⬇️

Copy link
Collaborator

@rhuss rhuss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks ! looks good to me

@rhuss rhuss merged commit 82a95dc into fabric8io:master Apr 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants